AllBugsFeaturesChangelogSearchNew post
Sign in with Fluxer
Bugs

[Web Client] Settings search results include a lot of things that don't match the search term

(#733) Bug Fixed search ui
by RexSystem edited originally by @Sollace on GitHub

Summary

When I search for a setting I expect it to show me the settings that match. Instead of shows the entire page of settings. Also you cannot navigate between menus with a search active because clicking on the menu items clears the search box. i.e. When I search for "display name" I expect it to find the "Display Name" option from the profile tab. Instead it finds:
  • Profile Type
  • Username
  • Display Name
  • Pronouns
  • Avatar
  • Banner
  • Accent Color
  • About Me
  • Theme
  • Sync theme across devices
  • Custom Theme Tokens
  • Messages (Comfy/Dense)
  • Space between message Groups
  • Channel list typing indicators
  • Show typing on selected channel
  • ....

Steps to reproduce

  1. Open user settings (Ctrl+,)
  2. Type "display name" in the search box

Environment

Flatpak

Logs or screenshots

image
  • 620947385-30af60cf-4845-43b3-9d1d-a33d844d7c5a.png

    620947385-30af60cf-4845-43b3-9d1d-a33d844d7c5a.png

    1767×1248 | 191 kB

6 comments

Sign in with Fluxer to comment and vote.
Comment by @Sollace
RexSystem 1 vote originally by @Sollace on GitHub OP
Additionally it has a category header with a list of the things that actually matched, but it's not helpful since you can't click the setting names to go directly to them. Clicking just collapses and expands the section.
Permalink
Comment by @Sollace
RexSystem 1 vote originally by @Sollace on GitHub OP
Also the git version that a friend is running (I still don't know why they are so different) image
  • 620953387-a1d71cbb-994a-47b0-9441-a2d156e9685b.png

    620953387-a1d71cbb-994a-47b0-9441-a2d156e9685b.png

    1752×1259 | 255 kB

Permalink
Comment by @liamt8d
RexSystem 1 vote originally by @liamt8d on GitHub
Hi! I worked on the Settings Search issue and pushed the changes to my branch fix/settings-search-1395. The updated matching logic now requires every word in the search query to match at least one field of a setting, instead of accepting results when only part of the query matches. I also tried running the typecheck, but it is currently blocked on Windows by an issue in tools/dev/src/tunnel.rs:373. Would it be okay for me to open a Pull Request with these changes?
Permalink
Comment by Hampus
HampusStaff 1 vote originally by @hampus-fluxer on GitHub
Hi! I worked on the Settings Search issue and pushed the changes to my branch fix/settings-search-1395. The updated matching logic now requires every word in the search query to match at least one field of a setting, instead of accepting results when only part of the query matches. I also tried running the typecheck, but it is currently blocked on Windows by an issue in tools/dev/src/tunnel.rs:373. Would it be okay for me to open a Pull Request with these changes?
I've sent you an invite to become a collaborator for temporary PR access. Thanks!
Permalink