Instead of rendering the green ring when your voice is detected by VOIP, do it locally to avoid looking like it's laggy

(#1069) Feature Open: Under consideration ui voice

Problem

Right now, when saying something over a call, looks like you're having a lot of lag before the voice arrives. 558345040-5de199ea-f64f-40e4-a413-b5659a5b3caa.mp4 Sorry if it's hard to understand, English isn't my main language.

Proposed solution

Rendering specifically your voice's green ring locally, but keep the other users' rings as it already is. This way, it wouldn't look like your voice has any delays. It's a simple visual fix but makes a lot of difference in how people notice lag. Besides, we can already see the exact latency by hovering our mouse in the connection symbol anyways, so it's not like we're hiding it from users, just making it feel nicer.
  1. The pull request fluxer#3503 mentions this post Merged

4 comments

Sign in with Fluxer to comment and vote.
Comment by @Kawwabi
RexSystem 5 votes originally by @Kawwabi on GitHub OP 2 replies
also, unrelated, but could we have a little different rings than Discord's? I was thinking about something like an audio ring equalizer, like this: image It's theoretically not too graphic intensive and would distinct the two platforms in a way that makes Fluxer feel better due to the additional information visible by the rings (you could see who's screaming in a 5+ person call easily by looking at how big the ring is, spotting it quickly so you can mute it).
Comment by sophie 🌸
sophie 🌸 4 votes 1 reply
indicating who's being loud is honestly genius. i think it might not be a bad idea to have the ring not resize but change colour to amber or red if someone's getting loud.
Comment by fltx
This is a major problem, the ring activity is very misleading in its current implementation. I am not sure its an issue with the icon rendering by determination of the server, it seems to just light up based upon a dB threshold. Using push to talk for example, it should stay illuminated for the whole duration the PTT button is pressed, not only when a volume threshold is met. The same applies for non-PTT users though, low volume inputs DO get passed through to the voice call, but the ring doesn't illuminate indicating it does, thus its misleading and hard to diagnose if users can hear background noise, etc. EDIT: audio analyser (https://github.com/fluxerapp/fluxer/blob/2d8d130be1839c61e31dae32975dfd522aa46b99/fluxer_app/src/features/voice/engine/VoiceSpeakingDetection.ts#L14-L29), thresholds and timing (https://github.com/fluxerapp/fluxer/blob/2d8d130be1839c61e31dae32975dfd522aa46b99/fluxer_app/src/features/voice/engine/VoiceSpeakingThreshold.ts#L3-L13). This is the code that controls this, it seems to samples audio every 50 ms and compares its RMS level against a threshold. At the default sensitivity, that threshold is 0.006 RMS, approximately −44 dBFS which requires 30 ms above threshold to trigger, then holds the indicator for 220 ms below threshold before clearing it. This is annoying because mice clicks are like sometimes very quick, fairly quite and don't trigger the ring! ----- I've used AI to fix this in my local deployment. It is complete vibe coded, It hasn't been verified on anything other than Linux. This code is ass, do not upstream, but if you wanna patch this locally, check my fork with the PR. https://github.com/WatchCollector67/flit-fluxer-fork/pull/1/changes I will not be submitting a PR upstream, as its AI generated.