Comment history

Versions of a comment on Instead of rendering the green ring when your voice is detected by VOIP, do it locally to avoid looking like it's laggy, newest first.

Current version | Edited by fltx
Changes
This is the code that controls this, it seems to samples audio every 50 ms and compares its RMS level against a threshold. At the default sensitivity, that threshold is 0.006 RMS, approximately −44 dBFS which requires 30 ms above threshold to trigger, then holds the indicator for 220 ms below threshold before clearing it. This is annoying because mice clicks are like sometimes very quick, fairly quite and don't trigger the ring!Added: Added: -----Added: Added: I've used AI to fix this in my local deployment. It is complete vibe coded, It hasn't been verified on anything other than Linux. This code is ass, do not upstream, but if you wanna patch this locally, check my fork with the PR. https://github.com/WatchCollector67/flit-fluxer-fork/pull/1/changesAdded: Added: I will not be submitting a PR upstream, as its AI generated.
Show
This is a major problem, the ring activity is very misleading in its current implementation. I am not sure its an issue with the icon rendering by determination of the server, it seems to just light up based upon a dB threshold. Using push to talk for example, it should stay illuminated for the whole duration the PTT button is pressed, not only when a volume threshold is met. The same applies for non-PTT users though, low volume inputs DO get passed through to the voice call, but the ring doesn't illuminate indicating it does, thus its misleading and hard to diagnose if users can hear background noise, etc. EDIT: audio analyser (https://github.com/fluxerapp/fluxer/blob/2d8d130be1839c61e31dae32975dfd522aa46b99/fluxer_app/src/features/voice/engine/VoiceSpeakingDetection.ts#L14-L29), thresholds and timing (https://github.com/fluxerapp/fluxer/blob/2d8d130be1839c61e31dae32975dfd522aa46b99/fluxer_app/src/features/voice/engine/VoiceSpeakingThreshold.ts#L3-L13). This is the code that controls this, it seems to samples audio every 50 ms and compares its RMS level against a threshold. At the default sensitivity, that threshold is 0.006 RMS, approximately −44 dBFS which requires 30 ms above threshold to trigger, then holds the indicator for 220 ms below threshold before clearing it. This is annoying because mice clicks are like sometimes very quick, fairly quite and don't trigger the ring! ----- I've used AI to fix this in my local deployment. It is complete vibe coded, It hasn't been verified on anything other than Linux. This code is ass, do not upstream, but if you wanna patch this locally, check my fork with the PR. https://github.com/WatchCollector67/flit-fluxer-fork/pull/1/changes I will not be submitting a PR upstream, as its AI generated.
Edited by fltx
Changes
Using push to talk for example, it should stay illuminated for the whole duration the PTT button is pressed, not only when a volume threshold is met. The same applies for non-PTT users though, low volume inputs DO get passed through to the voice call, but the ring doesn't illuminate indicating it does, thus its misleading and hard to diagnose if users can hear background noise, etc.Added: Added: EDIT: Added: Added: audio analyser (https://github.com/fluxerapp/fluxer/blob/2d8d130be1839c61e31dae32975dfd522aa46b99/fluxer_app/src/features/voice/engine/VoiceSpeakingDetection.ts#L14-L29),Added: Added: thresholds and timing (https://github.com/fluxerapp/fluxer/blob/2d8d130be1839c61e31dae32975dfd522aa46b99/fluxer_app/src/features/voice/engine/VoiceSpeakingThreshold.ts#L3-L13).Added: Added: This is the code that controls this, it seems to samples audio every 50 ms and compares its RMS level against a threshold. At the default sensitivity, that threshold is 0.006 RMS, approximately −44 dBFS which requires 30 ms above threshold to trigger, then holds the indicator for 220 ms below threshold before clearing it. This is annoying because mice clicks are like sometimes very quick, fairly quite and don't trigger the ring!
Show
This is a major problem, the ring activity is very misleading in its current implementation. I am not sure its an issue with the icon rendering by determination of the server, it seems to just light up based upon a dB threshold. Using push to talk for example, it should stay illuminated for the whole duration the PTT button is pressed, not only when a volume threshold is met. The same applies for non-PTT users though, low volume inputs DO get passed through to the voice call, but the ring doesn't illuminate indicating it does, thus its misleading and hard to diagnose if users can hear background noise, etc. EDIT: audio analyser (https://github.com/fluxerapp/fluxer/blob/2d8d130be1839c61e31dae32975dfd522aa46b99/fluxer_app/src/features/voice/engine/VoiceSpeakingDetection.ts#L14-L29), thresholds and timing (https://github.com/fluxerapp/fluxer/blob/2d8d130be1839c61e31dae32975dfd522aa46b99/fluxer_app/src/features/voice/engine/VoiceSpeakingThreshold.ts#L3-L13). This is the code that controls this, it seems to samples audio every 50 ms and compares its RMS level against a threshold. At the default sensitivity, that threshold is 0.006 RMS, approximately −44 dBFS which requires 30 ms above threshold to trigger, then holds the indicator for 220 ms below threshold before clearing it. This is annoying because mice clicks are like sometimes very quick, fairly quite and don't trigger the ring!
Original by fltx
Show
This is a major problem, the ring activity is very misleading in its current implementation. I am not sure its an issue with the icon rendering by determination of the server, it seems to just light up based upon a dB threshold. Using push to talk for example, it should stay illuminated for the whole duration the PTT button is pressed, not only when a volume threshold is met. The same applies for non-PTT users though, low volume inputs DO get passed through to the voice call, but the ring doesn't illuminate indicating it does, thus its misleading and hard to diagnose if users can hear background noise, etc.