FxEmbed Domains Hard-Coded

(#581) Bug Open: Confirmed Priority: P2 embeds

Summary

Currently FxEmbeds work only from specific domains not all. Literally anyone can get a domain and use it for FxEmbed, so hardcoding them is not a good idea, https://github.com/fluxerapp/fluxer/blob/fa3e8525755dae087c03ceaf83b814cbe46c7228/fluxer_unfurl/src/resolvers/fxtwitter.rs#L23 Meanwhile vxtwitter does seem to embed at all, and normal twitter embeds have the same issues. Possibly treat them based on property="twitter:*" instead of domain name

Steps to reproduce

  1. Send an post with fixupx.com
  2. Send the same post with different domain not mentioned above
  3. Compare the embeds

Environment

Canary Desktop 2026.602.31138 Web 2026.605.11941 Linux 7.0.12-arch1-1 (x64) Electron 41.2.2 Chrome 146.0.7680.188 Node 24.14.1 Locale en-US

3 comments

Sign in with Fluxer to comment and vote.
Comment by bizo
bizoReviewer 1 vote
Status changed from Needs triage to Confirmed
Canary Desktop 2026.1006.171724, Web 2026.1006.190110, Windows 11 10.0.26200 (x64), Electron 44.4.1, Chrome 152.0.7977.78, Node 24.21.0, Locale en-GB
Comment by @yofukashino
RexSystem 1 vote originally by @yofukashino on GitHub OP
Another small bug related to unfurler and fxembeds, so can be included with this. Tweets with GIFs are rendered as tweets with videos, treating the GIFs as video. (Find examples yourself, my feed is not sfw)
Deleted comment
Removed by moderator Rex: Removed a general status note that was posted on many GitHub threads. It no longer applies here.
Comment by Fullest
should be noted that vxtwitter doesn't run fxembed, but bettertwitfix, which I don't think has been updated to allow sending embed info to fluxer like fxembed has. so that's probably the reason vxtwitter doesn't embed currently. And normal twitter links working/not working really is just up to whether twitter themselves feel like sending embeds to fluxer. I think at the time this was originally submitted, they were refusing to send embed data, but they started randomly sending (scuffed) embeds a few months ago.