AllBugsFeaturesChangelogSearchNew post
Sign in with Fluxer
Bugs

FxEmbed Domains Hard-Coded

(#581) Bug Needs triage embeds
by RexSystem edited originally by @yofukashino on GitHub

Summary

Currently FxEmbeds work only from specific domains not all. Literally anyone can get a domain and use it for FxEmbed, so hardcoding them is not a good idea, https://github.com/fluxerapp/fluxer/blob/fa3e8525755dae087c03ceaf83b814cbe46c7228/fluxer_unfurl/src/resolvers/fxtwitter.rs#L23 Meanwhile vxtwitter does seem to embed at all, and normal twitter embeds have the same issues. Possibly treat them based on property="twitter:*" instead of domain name

Steps to reproduce

  1. Send an post with fixupx.com
  2. Send the same post with different domain not mentioned above
  3. Compare the embeds

Environment

Canary Desktop 2026.602.31138 Web 2026.605.11941 Linux 7.0.12-arch1-1 (x64) Electron 41.2.2 Chrome 146.0.7680.188 Node 24.14.1 Locale en-US

1 comment

Sign in with Fluxer to comment and vote.
Comment by @yofukashino
RexSystem 1 vote originally by @yofukashino on GitHub OP
Another small bug related to unfurler and fxembeds, so can be included with this. Tweets with GIFs are rendered as tweets with videos, treating the GIFs as video. (Find examples yourself, my feed is not sfw)
Permalink
Deleted comment
Removed by moderator Rex: Removed a general status note that was posted on many GitHub threads. It no longer applies here.