Non-US Phone Numbers cannot be added

(#94) Bug Fixed i18n security

Summary

When I attempt to add my phone number as an additional security measure under Settings > Account > Phone Number this is not possible as austrian phone numbers (and likely many others around the world) do not follow the ###-###### format that is expected by Fluxer. It correctly detects my Country to be Austria (+43) but our phone numbers are of the format #### ####### instead,

Steps to reproduce

  1. Go to Settings
  2. Go to Security & Login
  3. Go to Account
  4. Try to add a phone number
  5. Attempt to enter a phone number longer than 9 digits
  6. Notice that the phone number gets cut off

Environment (optional)

  • Commit Tag: 9494cce
  • OS: Linux 6.19.0-2-cachyos (x64)
  • Runtime: Electron 39.2.7

4 comments

Sign in with Fluxer to comment and vote.
Comment by @NoctisDNS
RexSystem 1 vote originally by @NoctisDNS on GitHub
Just FYI USA phone numbers are also longer than 9 digits, they are 10. Its not for USA. USA are ###-###-#### /lh On mobile webapp I dont even see an option to add a phone number. Im not sure if that was done as a stop gap or is a separate issue somewhat related to this one.
Comment by @AstralPhnx
RexSystem 1 vote originally by @AstralPhnx on GitHub
Worth noting that at least for here in New Zealand, some of our numbers start with a 0 and in those cases you can safely drop the 0 from the start of the phone number and it will add successfully. Tested this myself
Comment by @Wolvan
RexSystem 1 vote originally by @Wolvan on GitHub OP
I am aware of that, but even with dropping the leading 0, it still is too limited
Comment by @Jiralite
RexSystem 1 vote originally by @Jiralite on GitHub
This should be resolved. Please speak up otherwise!