Voice channels are options when forwarding messages

(#415) Bug Fixed messaging

6mo agoby FullestReviewer edited by moderator originally by @Emptiest on GitHub

Thread

RexSystem 1 vote 6mo ago originally by @cproudlock on GitHub

The issue is in fluxer_app/src/components/modals/shared/ForwardChannelSelection.tsx lines 31-35. FORWARDABLE_CHANNEL_TYPES dynamically includes all channel types except GUILD_CATEGORY:

const FORWARDABLE_CHANNEL_TYPES = new Set<number>(
    Object.values(ChannelTypes)
        .filter((value) => typeof value === 'number' && value !== ChannelTypes.GUILD_CATEGORY)
        .map((value) => Number(value)),
);

This includes GUILD_VOICE (type 2), which can't receive text messages. The fix is to use the existing TEXT_BASED_CHANNEL_TYPES constant from @fluxer/constants/src/ChannelConstants:

import {ChannelTypes, TEXT_BASED_CHANNEL_TYPES} from '@fluxer/constants/src/ChannelConstants';

const FORWARDABLE_CHANNEL_TYPES = TEXT_BASED_CHANNEL_TYPES;

Permalink