Embed link parsing issue

7mo agoby RexSystem edited originally by @Ly-sec on GitHub

Summary

Hello there, I meant to report this a few days ago but I forgot. When I post specific embeds with a ' in the link it fails to properly hide the link.

Steps to reproduce

Go to GIF selection -> select gif with ' in link

Logs or screenshots (optional)

I think this isn't only related to the GIF selector but it's an overall link issue. Here is one link to test: https://tenor.com/view/smug-frieren-frieren-beyond-journey's-end-sousou-no-frieren-anime-gif-7880495752394939238 image

554043096-5e917ea3-9dbf-4170-8caf-99739b198431.png
1080×1065 | 756 kB

History

3 comments

RexSystem 1 vote 7mo ago originally by @Sylos-Creator on GitHub

This looks like a url encoding issue and string escapes. I can try to take a look at this one if allowed. I suspect just str replace into url encoded form would work as a workaround but it's not a super user friendly workaround. the url encoded version of this that probably wouldn't break in the UI is this: https://tenor.com/view/smug-frieren-frieren-beyond-journey%27s-end-sousou-no-frieren-anime-gif-7880495752394939238

Permalink

RexSystem 1 vote 7mo ago originally by @Ly-sec on GitHub OP

This looks like a url encoding issue and string escapes. I can try to take a look at this one if allowed. I suspect just str replace into url encoded form would work as a workaround but it's not a super user friendly workaround. the url encoded version of this that probably wouldn't break in the UI is this: https://tenor.com/view/smug-frieren-frieren-beyond-journey%27s-end-sousou-no-frieren-anime-gif-7880495752394939238

That doesn't look that terrible to me to be fair. Just checked how discord handles it and in fact they do the exact same thing that you mentioned :) That's the link from discord

https://tenor.com/view/smug-frieren-frieren-beyond-journey%27s-end-sousou-no-frieren-anime-gif-7880495752394939238